Add Genesis schemas and fix doc deployment by cmungall · Pull Request #50 · linkml/valuesets

cmungall · 2026-02-21T22:20:51Z

Summary

Three commits:

Add 19 Genesis Mission schema modules - The YAML source schemas for energy/grid, nuclear, earth science, computing, industry, materials/physics, and bioprocessing/labs domains. Also updates valuesets.yaml imports.
Add generated enums and datamodel - Rich Python enums, datamodel, and merged schema generated from the new schemas.
Fix deploy-docs and enhance regen-derived workflows:
- deploy-docs.yaml: Run gen-project before gen-doc so element pages for all schema modules are generated before mkdocs builds. This fixes the broken links on the genesis-mission overview page (element pages were missing because gen-doc alone doesn't process new schema modules into the merged schema).
- regen-derived.yaml: Add gen-sssom to regenerate SSSOM ontology mapping files.

Root cause of broken links

The genesis-mission.md page linked to element pages like AquiferType.md, but those element pages were never generated in CI because:

The 19 new schema YAML files were not committed to main
The deploy workflow only ran gen-doc (not gen-project), so the merged schema didn't include new modules

Test plan

Merge and verify deploy-docs workflow generates element pages without warnings
Verify links from genesis-mission page resolve correctly on live site
Trigger regen-derived manually and verify gen-sssom runs

🤖 Generated with Claude Code

New domain schemas covering DOE Genesis challenges: - Energy: grid, subsurface_energy - Nuclear: fusion, nuclear_cleanup, nuclear_forensics - Earth Science: subsurface, hydrogeology, remote_sensing, water_resources - Computing: data_centers, microelectronics, quantum - Industry: manufacturing, construction, unconventional_resources - Materials/Physics: computational_materials, particle_physics - Bioprocessing/Labs: biomanufacturing, autonomous_labs Also updates the main valuesets.yaml imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Generated Python rich enums, datamodel, and merged schema for the 19 new Genesis Mission schema modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

deploy-docs: Run gen-project before gen-doc so element pages for all schema modules (including new ones) are generated before mkdocs builds the site. This fixes broken links on the live site. regen-derived: Add gen-sssom step to regenerate SSSOM ontology mapping files alongside project and doc files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

claude · 2026-02-21T22:21:06Z

Claude finished @cmungall's task —— View job

PR Review Analysis

I've completed my review of this large merged PR that adds 19 Genesis Mission schema modules and fixes documentation deployment. Here's my comprehensive feedback:

🎯 Overall Assessment: Good Quality Implementation

This is a well-structured addition that follows project conventions and successfully addresses the broken link issue.

✅ Strengths

Code Quality & Best Practices

Excellent organization: New schemas are properly nested by domain (energy/, computing/, earth_science/, etc.) following the project structure
Consistent naming: All enum names use CamelCase as per guidelines (FusionConfinementType, QubitType, etc.)
Proper LinkML structure: All schemas follow correct LinkML patterns with proper imports, prefixes, and metadata
Rich ontology mappings: Extensive use of meaning: fields with proper CURIE notation (CHEBI:30212, NCIT:C62378)
Comprehensive documentation: Each enum includes detailed descriptions and proper contributor attribution

Generated Code Quality

Clean Python enum generation with proper metadata preservation
Follows established patterns from existing codebase
Proper imports and class structure maintained

Workflow Improvements

Critical fix: Adding gen-project before gen-doc correctly resolves the broken links issue
Smart enhancement: Adding gen-sssom to regen workflow improves ontology mapping maintenance
Both changes address real operational needs

⚠️ Areas of Concern

Scale & Review Burden

Very large PR: 10,739 additions across 46 files makes comprehensive review challenging
Generated content dominance: Significant portion is auto-generated, making manual verification difficult

Minor Quality Issues

Some contributor entries use placeholder GitHub URLs (https://github.com/anthropics/claude-code) rather than proper ORCID IDs
A few schemas have minimal ontology mappings that could be expanded
Status consistently marked as "DRAFT" - consider graduation criteria

🔒 Security Assessment: Clean

No security vulnerabilities identified
All external references use proper HTTPS URLs
Workflow changes don't introduce security risks
Generated code follows safe patterns

🚀 Performance Considerations

Large number of new imports in main schema may increase load time slightly
Generated enum files are reasonably sized and well-structured
Workflow changes should improve CI efficiency by avoiding regeneration failures

📋 Test Coverage

Missing: No tests for the new schema modules
Recommendation: Add validation tests for key Genesis schemas
Generated code inherits existing test coverage patterns

🎯 Specific Recommendations

Future PRs: Consider breaking down large schema additions into smaller, domain-focused PRs
Documentation: Add validation tests for critical Genesis schemas
Metadata: Replace placeholder GitHub contributor URLs with proper ORCID identifiers where possible
Ontology: Continue expanding meaning: mappings for better semantic interoperability

✅ Root Cause Fix Validation

The workflow fix correctly addresses the broken links issue:

gen-project now runs before gen-doc, ensuring merged schema includes all modules
Element pages for new enums will be generated properly
This should resolve the 404s on the genesis-mission overview page

Verdict: Well-executed implementation that successfully adds substantial domain coverage while fixing critical deployment issues. The code quality is high and follows established patterns. Recommend approval with minor suggestions for future improvements.

Copilot

Pull request overview

This pull request adds 19 Genesis Mission schema modules covering DOE energy/grid, nuclear, earth science, computing, industry, materials/physics, and bioprocessing/labs domains. It also fixes the documentation deployment workflow and enhances the regen-derived workflow.

Changes:

Adds 19 new schema YAML files with corresponding generated Python enums and datamodel
Fixes deploy-docs workflow to run gen-project before gen-doc, ensuring element pages are generated
Adds gen-sssom to regen-derived workflow for regenerating SSSOM ontology mapping files

Reviewed changes

Copilot reviewed 43 out of 46 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/valuesets/schema/valuesets.yaml	Adds imports for all 19 new schema modules
src/valuesets/schema/physics/particle_physics.yaml	Particle accelerators and fundamental particles schema
src/valuesets/schema/materials_science/computational_materials.yaml	Computational materials methods and property prediction schema
src/valuesets/schema/lab_automation/autonomous_labs.yaml	AI-driven autonomous laboratories schema
src/valuesets/schema/industry/unconventional_resources.yaml	Unconventional mineral resources and recovery methods schema
src/valuesets/schema/industry/manufacturing.yaml	Advanced manufacturing processes schema
src/valuesets/schema/industry/construction.yaml	Building systems and construction schema
src/valuesets/schema/energy/subsurface_energy.yaml	Subsurface energy resources and storage schema
src/valuesets/schema/energy/nuclear/nuclear_forensics.yaml	Nuclear forensics and attribution schema
src/valuesets/schema/energy/nuclear/nuclear_cleanup.yaml	Nuclear site cleanup and restoration schema
src/valuesets/schema/energy/nuclear/fusion.yaml	Fusion energy concepts and methods schema
src/valuesets/schema/energy/grid.yaml	Electrical grid components and management schema
src/valuesets/schema/earth_science/water_resources.yaml	Water resource types and quality (missing imports section)
src/valuesets/schema/earth_science/subsurface.yaml	Subsurface characterization and geophysical methods (missing imports section)
src/valuesets/schema/earth_science/remote_sensing.yaml	Remote sensing platforms and data types (missing imports section)
src/valuesets/schema/earth_science/hydrogeology.yaml	Aquifer types and groundwater processes (missing imports section)
src/valuesets/schema/computing/quantum.yaml	Quantum computing concepts schema
src/valuesets/schema/computing/microelectronics.yaml	Semiconductor and microelectronics schema
src/valuesets/schema/computing/data_centers.yaml	Data center infrastructure schema
src/valuesets/schema/bioprocessing/biomanufacturing.yaml	Biomanufacturing scales and processes schema
src/valuesets/enums/*	Generated Python enums from schemas
src/valuesets/enums/init.py	Updated with all new enum imports
src/valuesets/enums/mining_processing.py	Enhanced ExtractableTargetElement with detailed descriptions and ontology mappings
.github/workflows/deploy-docs.yaml	Runs gen-project before gen-doc and adds --force flag to deployment
.github/workflows/regen-derived.yaml	Adds gen-sssom command to regenerate SSSOM files

Copilot · 2026-02-21T22:24:35Z

src/valuesets/schema/earth_science/water_resources.yaml

+description: >-
+  Value sets for water resource types, water use categories, and water quality
+  relevant to the DOE 'Predicting U.S. Water for Energy' challenge
+id: https://w3id.org/valuesets/earth_science/water_resources


The imports: section is missing from this schema file. All LinkML schema files in this codebase should have an imports: section that includes at least - linkml:types. This is consistent with all other schema files in the repository and is required for proper schema processing. Add the missing imports section after the id field and before the prefixes section.

Copilot · 2026-02-21T22:24:36Z

src/valuesets/schema/earth_science/subsurface.yaml

+description: >-
+  Value sets for subsurface characterization, geophysical methods, and formation types
+  relevant to the DOE GEO-AI lighthouse and subsurface energy programs
+id: https://w3id.org/valuesets/earth_science/subsurface


The imports: section is missing from this schema file. All LinkML schema files in this codebase should have an imports: section that includes at least - linkml:types. This is consistent with all other schema files in the repository and is required for proper schema processing. Add the missing imports section after the id field and before the prefixes section.

Copilot · 2026-02-21T22:24:36Z

src/valuesets/schema/earth_science/hydrogeology.yaml

+title: Hydrogeology Value Sets
+description: >-
+  Value sets for hydrogeological characterization, aquifer types, and groundwater processes
+id: https://w3id.org/valuesets/earth_science/hydrogeology


The imports: section is missing from this schema file. All LinkML schema files in this codebase should have an imports: section that includes at least - linkml:types. This is consistent with all other schema files in the repository and is required for proper schema processing. Add the missing imports section after the id field and before the prefixes section.

Copilot · 2026-02-21T22:24:36Z

src/valuesets/schema/earth_science/remote_sensing.yaml

+description: >-
+  Value sets for remote sensing data types and platforms used in earth observation
+  and subsurface characterization
+id: https://w3id.org/valuesets/earth_science/remote_sensing


The imports: section is missing from this schema file. All LinkML schema files in this codebase should have an imports: section that includes at least - linkml:types. This is consistent with all other schema files in the repository and is required for proper schema processing. Add the missing imports section after the id field and before the prefixes section.

dragon-ai-agent and others added 3 commits February 21, 2026 16:19

Add generated enums and datamodel for Genesis schemas

2c06712

Generated Python rich enums, datamodel, and merged schema for the 19 new Genesis Mission schema modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 21, 2026 22:20

cmungall merged commit f833199 into main Feb 21, 2026
7 checks passed

Copilot started reviewing on behalf of cmungall February 21, 2026 22:21 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Genesis schemas and fix doc deployment#50

Add Genesis schemas and fix doc deployment#50
cmungall merged 3 commits intomainfrom
genesis-schemas-and-workflow-fixes

cmungall commented Feb 21, 2026

Uh oh!

Uh oh!

claude bot commented Feb 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cmungall commented Feb 21, 2026

Summary

Root cause of broken links

Test plan

Uh oh!

Uh oh!

claude bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Analysis

🎯 Overall Assessment: Good Quality Implementation

✅ Strengths

Code Quality & Best Practices

Generated Code Quality

Workflow Improvements

⚠️ Areas of Concern

Scale & Review Burden

Minor Quality Issues

🔒 Security Assessment: Clean

🚀 Performance Considerations

📋 Test Coverage

🎯 Specific Recommendations

✅ Root Cause Fix Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

claude bot commented Feb 21, 2026 •

edited

Loading